Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detectors): add alibaba cloud detector #590

Merged
merged 14 commits into from
Aug 9, 2021

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

  • Add resource detector support for Alibaba Cloud.
  • Alibaba Cloud has ~10% of the global market share, ranking third in the world and first in Asia-Pacific. Ref.

Short description of the changes

  • Bootstrap the package with Alibaba Cloud ECS detector.

@legendecas legendecas requested a review from a team as a code owner July 28, 2021 03:51
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #590 (c9bbac3) into main (a295efe) will decrease coverage by 0.04%.
The diff coverage is 95.19%.

❗ Current head c9bbac3 differs from pull request most recent head 20c47a0. Consider uploading reports for the commit 20c47a0 to get more accurate results

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
- Coverage   94.94%   94.90%   -0.05%     
==========================================
  Files         195      195              
  Lines       11637    11617      -20     
  Branches     1115     1091      -24     
==========================================
- Hits        11049    11025      -24     
- Misses        588      592       +4     
Impacted Files Coverage Δ
...try-resource-detector-alibaba-cloud/src/version.ts 0.00% <0.00%> (ø)
...oud/test/detectors/AlibabaCloudEcsDetector.test.ts 94.44% <94.44%> (ø)
...aba-cloud/src/detectors/AlibabaCloudEcsDetector.ts 97.72% <97.72%> (ø)
...urce-detector-alibaba-cloud/src/detectors/index.ts 100.00% <100.00%> (ø)
...detector-alibaba-cloud/src/semantic-conventions.ts 100.00% <100.00%> (ø)
...strumentation-document-load/src/instrumentation.ts
...entation-document-load/src/enums/AttributeNames.ts
...trumentation-document-load/src/enums/EventNames.ts
...metry-instrumentation-document-load/src/version.ts
...lemetry-instrumentation-document-load/src/utils.ts
... and 5 more

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just few nitpicks and one question

} from '@opentelemetry/test-utils';

const ALIYUN_HOST =
'http://' + alibabaCloudEcsDetector.ALIBABA_CLOUD_IDMS_ENDPOINT;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really http and not https ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is http. The address is not available in the public network. The IP range is reserved for carrier usage.

@dyladan
Copy link
Member

dyladan commented Aug 6, 2021

Can you please add yourself as owner to .github/component_owners.yml?

@legendecas
Copy link
Member Author

@dyladan updated :)

@dyladan dyladan merged commit e8c207b into open-telemetry:main Aug 9, 2021
@legendecas legendecas deleted the alibaba-cloud-detector branch August 10, 2021 02:32
@dyladan dyladan mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants