New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move aws/gcp detectors from opentelemetry-js repo #593
Conversation
13a6580
to
1ad1fdf
Compare
1ad1fdf
to
51d748a
Compare
Codecov Report
@@ Coverage Diff @@
## main #593 +/- ##
==========================================
+ Coverage 94.78% 94.94% +0.15%
==========================================
Files 179 195 +16
Lines 10976 11630 +654
Branches 1088 1115 +27
==========================================
+ Hits 10404 11042 +638
- Misses 572 588 +16
|
detectors/node/opentelemetry-resource-detector-gcp/package.json
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-aws/package.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor nits.
But i set it to need work to block merging until contrib 0.24.0 is out as these packages have been released already via core repo in version 0.24.0
detectors/node/opentelemetry-resource-detector-aws/package.json
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/opentelemetry-test-utils/package.json
@Flarna thanks for reviews. Updated, PTAL again :) |
detectors/node/opentelemetry-resource-detector-aws/package.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
This also requires a companion-PR to remove the code from |
is there an easy way to make diff this vs open-telemetry/opentelemetry-js#2392 ? |
@obecny suppose we have those two repo in a root directory, and opentelemetry-js is on main branch, we can use
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Which problem is this PR solving?
Fixes open-telemetry/opentelemetry-js#1689
Short description of the changes