Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct the build instructions #615

Merged
merged 2 commits into from Aug 14, 2021
Merged

docs: correct the build instructions #615

merged 2 commits into from Aug 14, 2021

Conversation

jessitron
Copy link
Contributor

@jessitron jessitron commented Aug 11, 2021 •
edited

Which problem is this PR solving?

  • The browser extension instructions for building from source did not work.

Short description of the changes

  • I updated the name of the repository, the directory, and the name of the script to run.

@jessitron jessitron requested a review from a team as a code owner August 11, 2021 21:34
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 11, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Aug 14, 2021 •
edited

Codecov Report

Merging #615 (037e499) into main (952e6d7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #615   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         204      204           
  Lines       11973    11973           
  Branches     1137     1137           
=======================================
  Hits        11378    11378           
  Misses        595      595

@vmarchaud vmarchaud added the documentation Improvements or additions to documentation label Aug 14, 2021
@vmarchaud vmarchaud merged commit 72b78e6 into open-telemetry:main Aug 14, 2021
@jessitron jessitron deleted the patch-1 branch August 19, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauno56 rauno56 rauno56 approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@MSNev MSNev MSNev approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jessitron @rauno56 @vmarchaud @MSNev