Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mysql2): remove unused test.js file #636

Merged
merged 7 commits into from
Aug 31, 2021

Conversation

YanivD
Copy link
Member

@YanivD YanivD commented Aug 24, 2021

Short description of the changes

  • mysql2: Removed test.js unused file

If there is usage for this file, please close this PR without merging.

@YanivD YanivD requested a review from a team as a code owner August 24, 2021 14:29
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #636 (f3f8db4) into main (9197fc3) will increase coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   96.68%   97.12%   +0.43%     
==========================================
  Files          13       17       +4     
  Lines         634     1148     +514     
  Branches      124      155      +31     
==========================================
+ Hits          613     1115     +502     
- Misses         21       33      +12     
Impacted Files Coverage Δ
...pentelemetry-instrumentation-mysql2/src/version.ts 100.00% <0.00%> (ø)
...elemetry-instrumentation-mysql2/test/mysql.test.ts 97.86% <0.00%> (ø)
...etry-instrumentation-mysql2/src/instrumentation.ts 95.00% <0.00%> (ø)
.../opentelemetry-instrumentation-mysql2/src/utils.ts 100.00% <0.00%> (ø)

@dyladan dyladan changed the title test(mysql2): remove unused test.js file chore(mysql2): remove unused test.js file Aug 24, 2021
@dyladan
Copy link
Member

dyladan commented Aug 24, 2021

I think this file was there as a local test so the instrumentation author could step through an uninstrumented execution with the debugger while developing the instr

@dyladan dyladan merged commit aec1518 into open-telemetry:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants