chore: fixing running task in a proper zone preserving the active zone #88
Conversation
obecny
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
obecny
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 94.51% 94.52%
=======================================
Files 62 62
Lines 3520 3522 +2
Branches 372 372
=======================================
+ Hits 3327 3329 +2
Misses 193 193
|
|
@open-telemetry/javascript-maintainers ^^ |
| } | ||
| return activeZone.run(() => { | ||
| try { | ||
| return plugin._tracer.withSpan(span as api.Span, () => { |
There was a problem hiding this comment.
Why do you have to do Type Assertion here (span as api.Span)?
There was a problem hiding this comment.
should not be required as the assertion on line 319 should remove undefined from the type
There was a problem hiding this comment.
this is a compiler error / issue. the internal _createSpan returns api.Span or undefined. Even though there is if check for span existence the compiler still complains. If you have a better idea how to change it I'm open for suggestion.
plugins/web/opentelemetry-plugin-user-interaction/test/userInteraction.test.ts
Outdated
Show resolved
Hide resolved
|
Thank you for getting this fixed @obecny. Can we release a new version for this package any time soon? |
|
Yes I'll try to cut this today or tomorrow |
Which problem is this PR solving?
Web tracer, zone context manager and User Interaction plugin does not work with Angular opentelemetry-js#1206
For full fix another PR is needed from sdk
open-telemetry/opentelemetry-js#1209
Short description of the changes