Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform agnostic way to read environment variables #1157

Closed
markwolff opened this issue Jun 9, 2020 · 2 comments · Fixed by #1191
Closed

Add platform agnostic way to read environment variables #1157

markwolff opened this issue Jun 9, 2020 · 2 comments · Fixed by #1191
Assignees
Labels
Discussion Issue or PR that needs/is extended discussion.

Comments

@markwolff
Copy link
Member

Add a platform agnostic based way to read environment variables. We can add a single helper util here to ultimately read from process.env, global, window, etc.

On startup a pre-aggregated list of environment variables could be loaded into an environment holder, or the utility function could access an environment variable at runtime.

getEnvironmentVariable(name: EnvironmentVariable): string

_Originally posted by @obecny in #1153 (comment)

@dyladan dyladan added the Discussion Issue or PR that needs/is extended discussion. label Jun 9, 2020
@obecny
Copy link
Member

obecny commented Jun 11, 2020

@markwolff are you already working on that, or it's available to grab ?

@markwolff
Copy link
Member Author

I haven't started on it yet. You can grab it

@markwolff markwolff added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jun 11, 2020
@obecny obecny self-assigned this Jun 11, 2020
@obecny obecny removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants