Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstrumentationAbstract#getConfig should return the type of the concrete instrumentation #2258

Closed
Flarna opened this issue Jun 5, 2021 · 2 comments

Comments

@Flarna
Copy link
Member

Flarna commented Jun 5, 2021

Is your feature request related to a problem? Please describe.

Quite a lot instrumentations extend the config. The protected _config: types.InstrumentationConfig; member is accessible to them but it misses the extra configuration options.

Describe the solution you'd like

The type returned by getConfig and accepted by setConfig should be that one from the concrete instrumentation (defaults to types.InstrumentationConfig if not specified).

Describe alternatives you've considered

  • downcast as needed
  • add a member in concrete instrumentation with concrete type (like here)
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Mar 28, 2022
@github-actions
Copy link

This issue was closed because it has been stale for 14 days with no activity.

SDK General Availability automation moved this from In progress to Done Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants