Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove http.route from http span attributes #2489

Closed
dyladan opened this issue Sep 22, 2021 · 3 comments · Fixed by #2494
Closed

Remove http.route from http span attributes #2489

dyladan opened this issue Sep 22, 2021 · 3 comments · Fixed by #2494
Assignees
Labels
bug Something isn't working

Comments

@dyladan
Copy link
Member

dyladan commented Sep 22, 2021

It seems to me we should actually not be setting the route parameter.

Originally posted by @dyladan in #2487 (comment)

According to the spec, the http.route parameter should be the low-cardinality template route like /user/:id. In the http instrumentation, we don't have access to that information and we populate the whole route like /user/123 but that information is already available in the http.target attribute.

@dyladan dyladan added the bug Something isn't working label Sep 22, 2021
@vmarchaud vmarchaud added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Sep 23, 2021
@vmarchaud
Copy link
Member

Note that we override it if another instrumentation (for http frameworks) has given the low cardinality route https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-instrumentation-http/src/utils.ts#L494

@dyladan
Copy link
Member Author

dyladan commented Sep 23, 2021

that's fine but if you're not using one of those instrumentations then it's a duplicated field (with http.target) so there's no reason to have it.

@mustafain117
Copy link
Contributor

@dyladan I can work on this, please assign this to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants