-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TraceStates on SamplingResults #2974
Comments
I moved this issue since this is part of the SDK (though the Sampler interface is not moved to this repo yet, tracking in #2961). |
thanks. I was just looking through our labels and we don't have a "required by spec" label. this isn't really a bug because it is working as designed, but the spec changed. Create a new label? Can probably consolidate spec-v1 and spec-v1.1 labels into it. |
Both SGTM. Though, I don't find the semver-minor to be very clear as it has reached 1.9.0 already and our API package is not following the semantics. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Not stale, need to be addressed after landing #3088. |
Spec v0.7.0 added the expectation that
SamplingResult
includes aTraceState
. Current spec text: ASamplingResult
contains...Task: Support ^ by adding a property
traceState?: TraceState
toSamplingResult
(src). Backwards compatibility: If aSamplingResult
lackstraceState
, assume the value is "current trace state; no changes". UpdateTracer
to implement the trace state updating described by the spec.References:
The text was updated successfully, but these errors were encountered: