Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All samplers are deprecated #3318

Closed
Eomm opened this issue Oct 10, 2022 · 2 comments · Fixed by #3319
Closed

All samplers are deprecated #3318

Eomm opened this issue Oct 10, 2022 · 2 comments · Fixed by #3319

Comments

@Eomm
Copy link

Eomm commented Oct 10, 2022

Reading the @opentelemetry/sdk-trace-base@1.7.0 docs, to customize the sampler option we should use:

  • const { ParentBasedSampler } = require('@opentelemetry/core')
  • const { AlwaysOnSampler } = require('@opentelemetry/core')
  • const { AlwaysOffSampler } = require('@opentelemetry/core')

but all these classes are deprecated

* @deprecated Use the one defined in @opentelemetry/sdk-trace-base instead.

What should I use?
Thks

@dyladan
Copy link
Member

dyladan commented Oct 10, 2022

This is a case of bad documentation. You should use the samplers in sdk-trace-base.

@legendecas
Copy link
Member

Thank you for reporting this! Updated the document of the sdk-trace-base at #3319.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants