Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dep @opentelemetry/api-logs not propagated #3794

Closed
SimenB opened this issue May 11, 2023 · 0 comments · Fixed by #3798
Closed

Peer dep @opentelemetry/api-logs not propagated #3794

SimenB opened this issue May 11, 2023 · 0 comments · Fixed by #3798
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc

Comments

@SimenB
Copy link
Contributor

SimenB commented May 11, 2023

What happened?

Steps to Reproduce

Upgraded from 0.38 to 0.39, and we started to get

image

Expected Result

No TS error

Actual Result

TS error

Additional Details

@opentelemetry/otlp-transformer has the peer dep declared, but @opentelemetry/exporter-trace-otlp-grpc does not.

OpenTelemetry Setup Code

n/a

package.json

{
  "dependencies": {
    "@opentelemetry/api": "^1.0.0",
    "@opentelemetry/core": "^1.0.0",
    "@opentelemetry/exporter-trace-otlp-grpc": "^0.39.0",
    "@opentelemetry/exporter-trace-otlp-http": "^0.39.0",
    "@opentelemetry/instrumentation": "^0.39.0",
    "@opentelemetry/instrumentation-dataloader": "^0.4.0",
    "@opentelemetry/instrumentation-dns": "^0.31.0",
    "@opentelemetry/instrumentation-fastify": "^0.31.0",
    "@opentelemetry/instrumentation-fs": "^0.7.0",
    "@opentelemetry/instrumentation-graphql": "^0.34.0",
    "@opentelemetry/instrumentation-grpc": "^0.39.0",
    "@opentelemetry/instrumentation-http": "^0.39.0",
    "@opentelemetry/instrumentation-pino": "^0.33.0",
    "@opentelemetry/instrumentation-redis": "^0.34.0",
    "@opentelemetry/resource-detector-gcp": "^0.28.0",
    "@opentelemetry/resources": "^1.0.0",
    "@opentelemetry/sdk-trace-node": "^1.0.0",
    "@opentelemetry/semantic-conventions": "^1.0.0"
  }
}

Relevant log output

[folio-tracing-node]: ../../node_modules/@opentelemetry/sdk-logs/build/src/LogRecord.d.ts(2,31): error TS2307: Cannot find module '@opentelemetry/api-logs' or its corresponding type declarations.
[folio-tracing-node]: ../../node_modules/@opentelemetry/sdk-logs/build/src/Logger.d.ts(1,31): error TS2307: Cannot find module '@opentelemetry/api-logs' or its corresponding type declarations.
[folio-tracing-node]: ../../node_modules/@opentelemetry/sdk-logs/build/src/LoggerProvider.d.ts(1,31): error TS2307: Cannot find module '@opentelemetry/api-logs' or its corresponding type declarations.
[folio-tracing-node]: ../../node_modules/@opentelemetry/sdk-logs/build/src/export/ReadableLogRecord.d.ts(4,37): error TS2307: Cannot find module '@opentelemetry/api-logs' or its corresponding type declarations.
[folio-tracing-node]: Process exited (exit code 2), completed in 15s 855ms
@SimenB SimenB added bug Something isn't working triage labels May 11, 2023
@pichlermarc pichlermarc added priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc and removed triage labels May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants