Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Experimental metrics from semantic_conventions/http-metrics (1.23.1) #4344

Closed
pragmaticivan opened this issue Dec 3, 2023 · 4 comments

Comments

@pragmaticivan
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, we have to implement these metrics via middleware. But I assume they should be coming from instrumentation packages. To foster better organization I would like to point engineers to use the supported instrumentation libraries by opentelmetry-js.

Describe the solution you'd like

Support:
Metric: http.server.active_requests
Metric: http.server.request.body.size
Metric: http.server.response.body.size

And:
Metric: http.client.request.body.size
Metric: http.client.response.body.size

^ if possible

Describe alternatives you've considered

I had to create a middleware to implement these metrics.

Additional context

The Java client has implemented these metrics already: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/09940563658c20076b3cc3df3ed7c792a55c4049/instrumentation-api-semconv/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpServerExperimentalMetrics.java#L59

@pragmaticivan
Copy link
Contributor Author

This ticket might be fully blocked by #4235

@pragmaticivan
Copy link
Contributor Author

pragmaticivan commented Dec 3, 2023

I tried implementing the active_requets metrics but the attributes are out of compliance with the latest spec.

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Feb 26, 2024
Copy link

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant