Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ioredis #535

Closed
naseemkullah opened this issue Nov 14, 2019 · 2 comments
Closed

ioredis #535

naseemkullah opened this issue Nov 14, 2019 · 2 comments
Assignees
@naseemkullah
Milestone
Alpha v0.3.2

Comments

@naseemkullah
Copy link
Member

naseemkullah commented Nov 14, 2019 •
edited
Loading

Is your plugin request related to a problem? Please describe.
Would like to trace calls to redis made by a client instantiation of ioredis

Is it applicable for Node or Browser or both
Node

Do you expect this plugin to be commonly used
Weekly Downloads: 549,097

What version of plugin are you interested in using
Versions: 4.14.1 and beyond

Additional context
https://www.npmjs.com/package/ioredis

census instrumentation reference (https://github.com/census-instrumentation/opencensus-node/tree/master/packages/opencensus-instrumentation-ioredis)
@mayurkale22 mayurkale22 added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Nov 14, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.4 milestone Nov 14, 2019
@naseemkullah
Copy link
Member Author

naseemkullah commented Nov 21, 2019 •
edited
Loading

census instrumentation reference: https://github.com/census-instrumentation/opencensus-node/tree/master/packages/opencensus-instrumentation-ioredis

opentelemetry redis plugin reference/inspiration: https://github.com/open-telemetry/opentelemetry-js/pull/503/files

@naseemkullah naseemkullah mentioned this issue Nov 21, 2019
Merged
@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Nov 26, 2019
@vmarchaud
Copy link
Member

I believe we can close this one since it has been merged

@dyladan dyladan closed this as completed Jan 1, 2020
@mayurkale22 mayurkale22 modified the milestones: Alpha v0.4, Alpha v0.3.2 Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naseemkullah naseemkullah

Labels
None yet
Projects
None yet
Milestone
Alpha v0.3.2
Development

No branches or pull requests
4 participants
@dyladan @vmarchaud @mayurkale22 @naseemkullah