Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jaeger traces get right-padded with '0's when used with jaeger propagator #742

Closed
dyladan opened this issue Jan 29, 2020 · 0 comments · Fixed by #743
Closed

Jaeger traces get right-padded with '0's when used with jaeger propagator #742

dyladan opened this issue Jan 29, 2020 · 0 comments · Fixed by #743
Assignees
@dyladan
Labels
bug Something isn't working

Comments

@dyladan
Copy link
Member

dyladan commented Jan 29, 2020 •
edited
Loading

The jaeger trace id is only 8 bytes (16 hex characters), and when it is exported to Jaeger it gets right-padded.

Left-padding the trace ID instead will make Jaeger understand that these are the same trace.
@dyladan dyladan added the bug Something isn't working label Jan 29, 2020
@dyladan dyladan changed the title Jaeger traces get right-padded with '0 Jaeger traces get right-padded with '0's when used with jaeger propagator Jan 29, 2020
@dyladan dyladan self-assigned this Jan 29, 2020
@dyladan dyladan mentioned this issue Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyladan dyladan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: left pad jaeger trace ids dynatrace-oss-contrib/opentelemetry-js
1 participant
@dyladan