Set default Propagators list and bash script flags #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapphil
approved these changes
Mar 26, 2024
We want the default propagators to include both w3c context and xray, so set `OTEL_PROPAGATORS=tracecontext,baggage,xray` if it isn't already set to something else. Users that send traces to X-Ray, especially if they enable Active Tracing, should override this value to `OTEL_PROPAGATORS=tracecontext,baggage,xray-lambda` to ensure proper span relationships. I also added some common bash flags to align with industry standard practice.
tylerbenson
force-pushed
the
tyler/propagator-defaults
branch
from
37187c2
to
0b2f8ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the default propagators to include both w3c context and xray, so set
OTEL_PROPAGATORS=tracecontext,baggage,xrayif it isn't already set to something else.Users (of tracer layers that have implemented
xray-lambda) that send traces to X-Ray, especially if they enable Active Tracing, should override this value toOTEL_PROPAGATORS=tracecontext,baggage,xray-lambdato ensure proper span relationships within X-Ray.I also added some common bash flags to align with industry standard practice.