Add secretsmanager confmap provider #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
approved these changes
May 15, 2024
nslaughter
approved these changes
May 20, 2024
|
I initially thought that it would be possible to use environment variables and some integration between lambda and secrets manager, but it seems that it is not possible and maybe it does not make sense because env vars values don't dynamically update across invocations, having said that I think it makes sense to include this confmap provider here. Not a blocker for this pr, but one thing that I wanted to understand is how much these confmap providers that require fetching the configuration from a remote place add to the cold start time. LGTM! thanks! |
rapphil
approved these changes
May 24, 2024
|
Resolved conflicts. |
|
@tylerbenson can we get this pull request merged? |
|
@hkarn-godaddy sorry. One last rebase please and I'll get it merged. |
|
PR updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds secretsmanagerprovider confmap provider from opentelemetry-collector-contrib repo.