This repository has been archived by the owner on May 25, 2022. It is now read-only.
Cleanup file input 2 #165
Merged
Cleanup file input 2 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djaglowski it is hard to see what has changed since git diff is unable to show it nicely. |
|
@tigrannajaryan That's correct. |
tigrannajaryan
approved these changes
Jun 1, 2021
jsirianni
added a commit
to observIQ/stanza
that referenced
this pull request
Jun 25, 2021
4 tasks
jsirianni
added a commit
to observIQ/stanza
that referenced
this pull request
Jun 25, 2021
jsirianni
added a commit
to observIQ/stanza
that referenced
this pull request
Jun 25, 2021
* reorg test files only, ported from open-telemetry/opentelemetry-log-collection#165 * port otel enhanced file input benchmarking open-telemetry/opentelemetry-log-collection#166
jsirianni
added a commit
to observIQ/stanza
that referenced
this pull request
Jun 25, 2021
* reorg test files only, ported from open-telemetry/opentelemetry-log-collection#165 * port otel enhanced file input benchmarking open-telemetry/opentelemetry-log-collection#166 * skip closing files that are already closed
jsirianni
added a commit
to observIQ/stanza
that referenced
this pull request
Jul 8, 2021
* reorg test files only, ported from open-telemetry/opentelemetry-log-collection#165 * port otel enhanced file input benchmarking open-telemetry/opentelemetry-log-collection#166 * skip closing files that are already closed * port otel file rotation tracking open-telemetry/opentelemetry-log-collection#182 * fix poll()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file input operator is in need of additional test coverage, as well as more thorough benchmarks.
In preparation for this effort, I would like to reorganize existing test code in a way that will make further PRs simpler to track.
This PR splits
file_test.gointo the following categories:util_test.gobenchmark_test.goTestBuildmoved toconfig_test.gorotation_test.gofile_test.go