This repository has been archived by the owner on May 25, 2022. It is now read-only.
Temporarily reduce codecov target #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would like to get #157 merged in, but the changes are almost entirely difficult to test error cases. I'm not suggesting that these are unimportant, but that there are more important things to do right now. We can set this higher later, and increase coverage over time.
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
=======================================
- Coverage 75.9% 75.8% -0.1%
=======================================
Files 95 95
Lines 4347 4347
=======================================
- Hits 3301 3299 -2
- Misses 730 732 +2
Partials 316 316
|
tigrannajaryan
approved these changes
Jun 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to get #157 merged, but the changes are almost entirely difficult to test error cases. I'm not suggesting that these are unimportant, but that there are more important things to do right now. We can set this higher later, and increase coverage over time.