This repository has been archived by the owner on May 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
feat(operator/recombine): do not combine logs before first_entry matches line #416
Merged
djaglowski
merged 5 commits into
open-telemetry:main
from
SumoLogic:drosiek-recombine-match
Mar 8, 2022
Merged
feat(operator/recombine): do not combine logs before first_entry matches line #416
djaglowski
merged 5 commits into
open-telemetry:main
from
SumoLogic:drosiek-recombine-match
Mar 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #416 +/- ##
=====================================
Coverage 75.1% 75.2%
=====================================
Files 83 83
Lines 4022 4025 +3
=====================================
+ Hits 3023 3027 +4
Misses 696 696
+ Partials 303 302 -1
|
…hes line Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
c921ac0
to
00be20f
Compare
djaglowski
reviewed
Feb 25, 2022
… for first entry Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
djaglowski
reviewed
Mar 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed response - on PTO last week.
This looks a lot better but I think needs one more small iteration to tidy it up.
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
djaglowski
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @sumo-drosiek
jsirianni
pushed a commit
to jsirianni/opentelemetry-log-collection
that referenced
this pull request
Mar 28, 2022
…hes line (open-telemetry#416) * feat(operator/recombine): do not combine logs before first_entry matches line Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415
do not combine logs before first_entry matches line
See attached issue for more details