Skip to content

Commit

Permalink
bugfix: fixing diableprometheusannotation casing
Browse files Browse the repository at this point in the history
  • Loading branch information
rivToadd committed Feb 26, 2024
1 parent 02e44fb commit 109c0de
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 7 deletions.
16 changes: 16 additions & 0 deletions .chloggen/default-prometheus-annotation-bugfix.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
component: operator

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Changing one of the fields to follow naming conventions with lowerCamelCase

# One or more tracking issues related to the change
issues: [2608]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
2 changes: 1 addition & 1 deletion apis/v1alpha1/opentelemetrycollector_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ type MetricsConfigSpec struct {
//
// +optional
// +kubebuilder:validation:Optional
DisablePrometheusAnnotations bool `json:"DisablePrometheusAnnotations,omitempty"`
DisablePrometheusAnnotations bool `json:"disablePrometheusAnnotations,omitempty"`
}

// ObservabilitySpec defines how telemetry data gets handled.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3867,7 +3867,7 @@ spec:
metrics:
description: Metrics defines the metrics configuration for operands.
properties:
DisablePrometheusAnnotations:
disablePrometheusAnnotations:
description: DisablePrometheusAnnotations controls the automatic
addition of default Prometheus annotations ('prometheus.io/scrape',
'prometheus.io/port', and 'prometheus.io/path')
Expand Down Expand Up @@ -5211,7 +5211,7 @@ spec:
description: Metrics defines the metrics configuration for
operands.
properties:
DisablePrometheusAnnotations:
disablePrometheusAnnotations:
description: DisablePrometheusAnnotations controls the
automatic addition of default Prometheus annotations
('prometheus.io/scrape', 'prometheus.io/port', and 'prometheus.io/path')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3864,7 +3864,7 @@ spec:
metrics:
description: Metrics defines the metrics configuration for operands.
properties:
DisablePrometheusAnnotations:
disablePrometheusAnnotations:
description: DisablePrometheusAnnotations controls the automatic
addition of default Prometheus annotations ('prometheus.io/scrape',
'prometheus.io/port', and 'prometheus.io/path')
Expand Down Expand Up @@ -5208,7 +5208,7 @@ spec:
description: Metrics defines the metrics configuration for
operands.
properties:
DisablePrometheusAnnotations:
disablePrometheusAnnotations:
description: DisablePrometheusAnnotations controls the
automatic addition of default Prometheus annotations
('prometheus.io/scrape', 'prometheus.io/port', and 'prometheus.io/path')
Expand Down
4 changes: 2 additions & 2 deletions docs/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -17812,7 +17812,7 @@ Metrics defines the metrics configuration for operands.
</tr>
</thead>
<tbody><tr>
<td><b>DisablePrometheusAnnotations</b></td>
<td><b>disablePrometheusAnnotations</b></td>
<td>boolean</td>
<td>
DisablePrometheusAnnotations controls the automatic addition of default Prometheus annotations ('prometheus.io/scrape', 'prometheus.io/port', and 'prometheus.io/path')<br/>
Expand Down Expand Up @@ -20322,7 +20322,7 @@ Metrics defines the metrics configuration for operands.
</tr>
</thead>
<tbody><tr>
<td><b>DisablePrometheusAnnotations</b></td>
<td><b>disablePrometheusAnnotations</b></td>
<td>boolean</td>
<td>
DisablePrometheusAnnotations controls the automatic addition of default Prometheus annotations ('prometheus.io/scrape', 'prometheus.io/port', and 'prometheus.io/path')<br/>
Expand Down

0 comments on commit 109c0de

Please sign in to comment.