Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java auto-instrumentation image 2.x #2529

Open
pavolloffay opened this issue Jan 17, 2024 · 3 comments
Open

Support Java auto-instrumentation image 2.x #2529

pavolloffay opened this issue Jan 17, 2024 · 3 comments
Labels
enhancement New feature or request needs triage

Comments

@pavolloffay
Copy link
Member

Component(s)

No response

Is your feature request related to a problem? Please describe.

Crated from #2514 (comment)

The Java agent 2.x has several breaking changes https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/tag/v2.0.0:

  • exporter changed to OTLP HTTP
  • instrumentation changes

Describe the solution you'd like

Operator should configure HTTP exporter if 2.x java agent is used.

Describe alternatives you've considered

No response

Additional context

No response

@TylerHelmuth
Copy link
Member

We should support publishing a 2.x image for the operator to use if configured, but continue to default to the 1.x image. I believe we'll also need to update some CI to support publishing both a 1.x and 2.x image for the next 6 months. I can take a look at that.

@pavolloffay
Copy link
Member Author

The image gets published when https://github.com/open-telemetry/opentelemetry-operator/blob/main/autoinstrumentation/java/version.txt#L1 changes. It should be fine to use it for both version streams.

@TylerHelmuth
Copy link
Member

@pavolloffay you're right. I coded up a solution that let's us maintain 2.x and 1.x versions simultaneously, but if you're ok with the value in versions.txt moving back and forth between 1.x and 2.x that is simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

No branches or pull requests

2 participants