Resolve bug where TA doesn't allocate all targets #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
force-pushed
the
target-issues
branch
from
5f8f3de
to
594462d
Compare
jaronoff97
changed the title
Aneurysm9
approved these changes
Aug 17, 2022
pavolloffay
approved these changes
Aug 18, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Resolve bug where TA doesn't allocate all targets * Cleanup cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses and closes #1037 by introducing a new hashing function that ensure no collisions between targets based on the target's label set. This also introduces a small change that scopes the target items list to be private within the allocator and a new getter to expose that to other packages. A new test was added as well to verify that this change works as expected.