Apache auto-instrumentation #1082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrlic
force-pushed
the
apache-instrumentation
branch
from
672ed5d
to
9bd7f40
Compare
|
I would propose to split the PR into:
|
pavolloffay
reviewed
Sep 15, 2022
| ``` | ||
|
|
||
| The Dockerfiles for auto-instrumentation can be found in [autoinstrumentation directory](./autoinstrumentation). | ||
| Follow the instructions in the Dockerfiles on how to build a custom container image. | ||
|
|
||
| >**Note:** For `Apache` auto-instrumentation, by default, instrumentation assumes httpd version 2.4. If you need to use version 2.2, or you need to adjust agent parameters, adjust instrumentation per following example: |
There was a problem hiding this comment.
This deserves a new section
There was a problem hiding this comment.
Hello Pavol,
thank you for your review. Based on you comments, I'd do a new set of PR's
- auto-instrumentation image build and documentation
- changes related to Instrumentation CRD - definition, validation, etc.
- Injection itself + e2e tests
- default settings in the operator
Would that be OK?
There was a problem hiding this comment.
yes, that would be perfect ❤️
| - manager.yaml |
|
no longer needed! #1236 did this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR proposes auto-instrumentation for applications running on Apache HTTPD server in K8S environment.
For instrumentation library, it uses https://github.com/open-telemetry/opentelemetry-cpp-contrib/tree/main/instrumentation/otel-webserver-module
For instrumentation itself, it adheres to the principles used for other languages already supported as much as possible.