Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing nil checks in collector validating webhook #1136

Merged

Conversation

kristinapathak
Copy link
Contributor

Separating this unit test and logic changes into their own PR as suggested here

@kristinapathak kristinapathak requested a review from a team as a code owner October 3, 2022 17:48
@pavolloffay pavolloffay changed the title add missing nil checks in validating webhook Add missing nil checks in collector validating webhook Oct 4, 2022
@pavolloffay
Copy link
Member

PR needs to be rebased

@pavolloffay pavolloffay merged commit cc715cc into open-telemetry:main Oct 6, 2022
@kristinapathak kristinapathak deleted the validating-webhooks-logic branch October 6, 2022 18:41
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
…y#1136)

* add missing nil checks in validating webhook

* fix imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants