Adds deepcopy missing implementation for TargetCPUUtilization field of AutoscalerSpec #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avadhut123pisal
changed the title
avadhut123pisal
force-pushed
the
missing-deepcopy-code-for-TargetCPUUtilization
branch
from
452c44d
to
aec7b0c
Compare
|
I am not sure how PR without missing generated code could have been committed. There should be a CI check to avoid merging this. |
avadhut123pisal
force-pushed
the
missing-deepcopy-code-for-TargetCPUUtilization
branch
from
aec7b0c
to
59e0993
Compare
pavolloffay
approved these changes
Oct 10, 2022
|
#1154 fixes the check |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…calerSpec (open-telemetry#1138) Co-authored-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running
make generate, found some code that is not committed yet to the repo, adding the same.