Skip .NET auto-instrumentation if OTEL_DOTNET_AUTO_HOME env var is already set #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor into prevent-incomplete-auto-instrumentation
…avadhut123pisal/opentelemetry-operator into prevent-incomplete-auto-instrumentation
…tor into skip-instrumentation-if-otel-dotnet-auto-home-set
pellared
approved these changes
Oct 17, 2022
Kielek
approved these changes
Oct 17, 2022
use errors.New() to get the error object instead of fmt.Errorf() Co-authored-by: Robert Pająk <pellared@hotmail.com>
use errors.New() to get the error object instead of fmt.Errorf() Co-authored-by: Robert Pająk <pellared@hotmail.com>
…ithub.com:avadhut123pisal/opentelemetry-operator into skip-instrumentation-if-otel-dotnet-auto-home-set
…tor into skip-instrumentation-if-otel-dotnet-auto-home-set
|
e2e test failed, I have restarted build |
…tor into skip-instrumentation-if-otel-dotnet-auto-home-set
Not sure why it is failing. Error is |
pavolloffay
approved these changes
Oct 19, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…ready set (open-telemetry#1177) * skips env var injection and sdk configurations if agent injection is skipped * mutate container at the last of SDK injection step * validate first and then mutate the container with env variables * fixes go lint issues * incorporates review comments * fixes go lint issue * removes return statement in case of failed instrumentation * skips auto-instrumentation if OTEL_DOTNET_AUTO_HOME is already set * use errors.New() to get the error object use errors.New() to get the error object instead of fmt.Errorf() Co-authored-by: Robert Pająk <pellared@hotmail.com> * use errors.New() to get the error object use errors.New() to get the error object instead of fmt.Errorf() Co-authored-by: Robert Pająk <pellared@hotmail.com> * replaces fmt.Errorf with error.New Co-authored-by: Robert Pająk <pellared@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1156