CRD defs for Apache HTTPD Autoinstrumentation #1305
Conversation
|
Updated with generated resources (make generate). |
|
Generated bundle for Apache Httpd CRD (make bundle). |
|
Version updated for make bundle |
|
Chngnd repo user to open-telemetry for make bundle |
| // Attrs defines Apache HTTPD agent specific attributes. The precedence is: | ||
| // `agent default attributes` > `instrument spec attributes` | ||
| // +optional | ||
| Attrs []corev1.EnvVar `json:"attrs,omitempty"` |
There was a problem hiding this comment.
what exactly is this configuring?
There was a problem hiding this comment.
The OTel module for Apache httpd has number of configurable attributes (listed at https://github.com/open-telemetry/opentelemetry-cpp-contrib/tree/main/instrumentation/otel-webserver-module in Configuration section). There are reasonable defaults and some will be set by the instrumentation process, this gives a means to override those defaults.
There was a problem hiding this comment.
Should we add this link to the godoc?
…chrlic/opentelemetry-operator into apache-instrumentation-v1.0-crd
|
linting failed. its fixed in: 5e800c8 |
|
|
||
| // Apache HTTPD server version. One of 2.4 or 2.2. Default is 2.4 | ||
| // +optional | ||
| Version string `json:"version,omitempty"` |
There was a problem hiding this comment.
for my curiosity how is this version used?
There was a problem hiding this comment.
Apache HTTPD used these days is either version 2.2 or (most of the time) 2.4. The OTel agent is a set of binary loadable modules and those are compiled against specific Apache HTTPD version - different headers etc. Therefore you have to use the specific version of agent.
There was a problem hiding this comment.
Based on the version setting, auto-instrumentation configures Apache HTTPD with the proper set of modules to be loaded. The docker image with the agent contains modules for both supported versions.
There was a problem hiding this comment.
Pavol,
could we move this forward, please?
…chrlic/opentelemetry-operator into apache-instrumentation-v1.0-crd
…chrlic/opentelemetry-operator into apache-instrumentation-v1.0-crd
|
Hi Pavol, |
* CRD defs for Apache HTTPD Autoinstrumentation * Generated resources for Apache Httpd CRD defs * Generated bundle for Apache Httpd CRD * Fixed version for "make bundle" * Makefile and version update * Chngnd repo user to open-telemetry for make bundle * Reverted changes in kustomization.yaml * Reverted changes in kustomization.yaml * Reverted chnages in kustomization.yaml * Apache HTTPD - Link to attributes doc * make bundle sync * ./.chloggen yaml added for open-telemetry#1305 * Version fix
This is a followup PR in Apache HTTPD Autoinstrumentation implementation project to previous PR #1236.
It contains CRD definition, defaults, validations, and test.
Next PR will contain the autoinstrumentation logic itself and e2e tests.