Refactor how images are pushed #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
force-pushed
the
jpkrohling/36-publish-images
branch
3 times, most recently
from
2e39f13
to
5f4d970
Compare
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkrohling/36-publish-images
branch
from
910dea7
to
f50eade
Compare
|
@kevinearls, would you review this one as well? |
kevinearls
approved these changes
Dec 14, 2020
|
|
||
| - name: Docker meta | ||
| id: docker_meta | ||
| uses: crazy-max/ghaction-docker-meta@v1 |
There was a problem hiding this comment.
crazy-max? Should we be depending on someone named crazy-max? :-)
There was a problem hiding this comment.
I had the exact thought. Unfortunately, the official docs for the Docker action recommends this one dynamic labels and tags.
|
I'm merging, as there's only one way of knowing it works. |
This was referenced Dec 16, 2020
Closed
Closed
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
…try#138) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
6 tasks
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…try#138) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed how images are pushed to registries, both for master and releases.