Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OpenShift routes work with missing hostname #2074

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Make OpenShift routes work with missing hostname #2074

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbb448b
Make OpenShift routes work with missing hostname
pavolloffay Aug 31, 2023
fbca270
Fix
pavolloffay Aug 31, 2023
0f6bde6
Fix
pavolloffay Sep 1, 2023
e8d48f1
Fix the changelog entry
pavolloffay Sep 4, 2023
4de1614
Update .chloggen/route-use-defaults.yaml
frzifus Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .chloggen/route-use-defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
component: operator
Expand All @@ -13,4 +13,4 @@ issues: [2074]
# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: The OpenShift route hostnames change to `<port-name>-<otel-cr-name>-route-<otel-cr-namespace>-basedomain` e.g. from `otlp-http.apps-crc.testing` to `otlp-http-otel-route-ploffay.apps-crc.testing`.
subtext: If the ingeress hostname is not specified OpenShift route hostname is set to `<port-name>-<otel-cr-name>-route-<otel-cr-namespace>-basedomain`.
frzifus marked this conversation as resolved.
Show resolved Hide resolved
Loading