Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Heartbeat and managed annotation checker to the bridge #2294

Merged
merged 10 commits into from
Nov 3, 2023
Merged

Add Heartbeat and managed annotation checker to the bridge #2294

merged 10 commits into from
Nov 3, 2023

Conversation

jaronoff97
Copy link
Contributor

Description:

  • Updates to latest opamp-go
  • Implements a heartbeat to keep connection alive
  • Updates the label check to comply with spec

Link to tracking Issue: #2132

Testing: Manual testing and some unit tests... more to come.

@jaronoff97 jaronoff97 requested a review from a team as a code owner October 30, 2023 20:58
@jaronoff97 jaronoff97 changed the title Add Heartbeat and managed annotation checker Add Heartbeat and managed annotation checker to the bridge Nov 1, 2023
matej-g
matej-g approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nicely done 👍

swiatekm
swiatekm approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left two nitpicks which shouldn't block merging.

cmd/operator-opamp-bridge/agent/agent_test.go Outdated Show resolved Hide resolved
cmd/operator-opamp-bridge/operator/client.go Outdated Show resolved Hide resolved
@jaronoff97 jaronoff97 merged commit 4b310f5 into open-telemetry:main Nov 3, 2023
27 checks passed
@jaronoff97 jaronoff97 deleted the add-managed-bridge-annotation branch November 3, 2023 15:18
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@jaronoff97
Add Heartbeat and managed annotation checker to the bridge (open-tele…
a61e474 
…metry#2294)

* add heartbeat, upgrade to latest

* chlog

* Fix tests

* pipe the name through

* set name in tests

* add health test

* Simplify

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matej-g matej-g matej-g approved these changes

@yuriolisa yuriolisa yuriolisa approved these changes

@swiatekm swiatekm swiatekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaronoff97 @matej-g @yuriolisa @swiatekm