Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to collector v0.24.0 #251

Merged
merged 1 commit into from Apr 22, 2021
Merged

Update to collector v0.24.0 #251

merged 1 commit into from Apr 22, 2021

Conversation

jnodorp-jaconi
Copy link
Contributor

@jnodorp-jaconi jnodorp-jaconi commented Apr 20, 2021

Fixes #238

@jnodorp-jaconi jnodorp-jaconi requested review from a team as code owners April 20, 2021 19:45
@jpkrohling
Copy link
Member

As discussed in the linked issue, I believe we need a small upgrade routine here.

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks!

@jpkrohling jpkrohling merged commit 41e5738 into open-telemetry:main Apr 22, 2021
@jnodorp-jaconi jnodorp-jaconi deleted the collector0.24.0 branch April 22, 2021 14:31
@jnodorp-jaconi
Copy link
Contributor Author

Looks awesome! Thanks!

That was fast, thanks! Mind to tag a release?

@jpkrohling
Copy link
Member

jpkrohling commented Apr 22, 2021

Release triggered. I just realized that there's an entry missing in the changelog, #248. Would you mind sending a PR fixing the changelog?

@jnodorp-jaconi
Copy link
Contributor Author

Release triggered. I just realized that there's an entry missing in the changelog, #248. Would you mind sending a PR fixing the changelog?

Thank you! You tagged 0.25.0, though. Did you skip the 0.24.0 intentionally?

There you go: #253

@jpkrohling
Copy link
Member

No, it was not on purpose. I did a release of the builder at the same time and ended up using the same version. I just removed the release, the tag, and triggered a new one for 0.24.0. Thanks for bringing this to my attention!

shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to collector v0.24.0
2 participants