Fix/config exporter endpoint panic #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexter0195
force-pushed
the
fix/config-exporter-endpoint-panic
branch
from
ba757e2
to
2feb5ba
Compare
swiatekm-sumo
approved these changes
Feb 21, 2024
Co-authored-by: Mikołaj Świątek <mail+sumo@mikolajswiatek.com>
jaronoff97
approved these changes
Feb 21, 2024
auto-merge was automatically disabled
February 22, 2024 06:24
Head branch was pushed to by a user without write access
|
Ready to merge whenever you want! Sorry for the hiccups on the CI 🙏 |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* fix: exporter panic on malformed endpoint configuration * feat: adds tests for Ports in exporter.go * add chloggen file * adds header + fix test * Update internal/manifests/collector/parser/exporter/exporter_test.go Co-authored-by: Mikołaj Świątek <mail+sumo@mikolajswiatek.com> * fix: test exporter_test.go --------- Co-authored-by: Mikołaj Świątek <mail+sumo@mikolajswiatek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a CrashLoopBackoff caused by a panic occurring when, in the
spec.config, the endpoint for the prometheus exporter is not valid.I integrated a simple check in
internal/manifests/collector/parser/exporter/exporter_prometheus.goon the functionfunc (o *PrometheusExporterParser) Ports() ([]corev1.ServicePort, error)to check ifsinglePortFromConfigEndpointis returning a nil pointer.Link to tracking Issue(s): #2628
Testing:
exporterpackage for Prometheus.