Daemonset vpa and doc fix #2659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rivToadd, please split it in two PRs, one for the Updates the Daemonset to allow for label selectors and another one for fixing the case for DisablePrometheusAnnotations. |
yuriolisa
requested changes
Feb 25, 2024
rivToadd
force-pushed
the
daemonset-vpa-and-doc-fix
branch
from
7c6eb5c
to
8df903d
Compare
|
Closing PR to change branch name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Keeps label selectors on daemonsets
Link to tracking Issue(s):
Testing:
Added tests for collector status and for 2605 use case
Documentation: