Golang instrumentation featuregates into cli #2750
Conversation
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
yuriolisa
changed the title
.chloggen/featuregates-into-cli.yaml
Outdated
| component: 'operator' | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Change featuregates auto-instrumentation.go to CLI |
There was a problem hiding this comment.
we should document exactly which flag is changing and what is the new flag.
|
The reason these tests fail is that this feature gate is enabled in the default manifests. #1555 added this, and I'm not entirely sure why. @TylerHelmuth do you recall? |
|
@swiatekm-sumo back then there was no other way (that I knew of at least) to enable the feature for the tests. Specific discussion here: #1555 (comment) |
Is there actually any difference between enabling the flag by default in the code vs doing so in the manifests? I want to understand if this instrumentation should be enabled or disabled by default. Right now, we have the ability to add operator flags for specific E2E test suites. |
Sweet, we should enable it for the tests that need it, but I think disabled by default is still correct since it is alpha. |
|
Clicked the wrong button |
|
@yuriolisa it sounds like you need to add something the following: And then use it in the CI for setup of instrumentation tests. |
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
* Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed e2e job Signed-off-by: Yuri Sa <yurimsa@gmail.com> --------- Signed-off-by: Yuri Sa <yurimsa@gmail.com>
* Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed featuregate into CLI - instrumentation go Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed e2e job Signed-off-by: Yuri Sa <yurimsa@gmail.com> --------- Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Description:
Changed featuregates.autoinstrumentation.go to cli.
Link to tracking Issue(s):
operator.autoinstrumentation.go#2675Testing:
Documentation: