Add a separate Params struct for Target Allocator #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancasa
approved these changes
Jun 17, 2024
jaronoff97
reviewed
Jun 17, 2024
Comment on lines
+64
to
+68
| Client: params.Client, | ||
| Scheme: params.Scheme, | ||
| Recorder: params.Recorder, | ||
| Log: params.Log, | ||
| Config: params.Config, |
There was a problem hiding this comment.
Given that these things are generic to any params, i wonder if it would be better to define a common type that always has these and the generic parameter is that type such that a TA params would just be
package targetallocator
type Params {
manifestutils.Params
Collector ...
TargetAllocator ....
}
There was a problem hiding this comment.
Sounds good to me, though I'd rather do this as a follow-up after the opamp bridge reconciler starts using its own Params struct as well.
swiatekm
force-pushed
the
chore/ta-params
branch
from
364f9e0
to
1bbf515
Compare
jaronoff97
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the builder definitions more generic to allow different Params structures for different builders. Use this to define a separate Params structure for the TargetAllocator.