Create a separate bundle for OpenShift installations #3056
Conversation
iblancasa
changed the title
|
Could you please create a changelog entry for this? |
config/manifests/community/bases/opentelemetry-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
|
The contributing.md should be probably updated as well |
Sure. I'll do. |
iblancasa
changed the title
| @@ -6,7 +6,7 @@ metadata: | |||
| capabilities: Deep Insights | |||
| categories: Logging & Tracing,Monitoring | |||
| certified: "false" | |||
| containerImage: ghcr.io/open-telemetry/opentelemetry-operator/opentelemetry-operator | |||
There was a problem hiding this comment.
Why is this being changed?
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
There was a problem hiding this comment.
Nice progress 👍🏼
https://github.com/open-telemetry/opentelemetry-operator/blob/main/CONTRIBUTING.md#create-the-bundle-and-related-images needs to be updated as well.
|
|
||
| $(OPERATOR_SDK) bundle validate ./bundle/community | ||
| $(OPERATOR_SDK) bundle validate ./bundle/openshift | ||
| rm bundle.Dockerfile |
There was a problem hiding this comment.
Why removing the bundle dockerfile? It was moved to ./bundle/
There was a problem hiding this comment.
It is generated again
| - op: add | ||
| path: "/spec/template/spec/containers/0/args" | ||
| value: | ||
| - --metrics-addr=127.0.0.1:8080 |
There was a problem hiding this comment.
Do we want to enable the RBAC creation flag as well?
There was a problem hiding this comment.
That flag does nothing now.
Description: create a separate bundle for OpenShift platform.
Resolves: #3054