componentParser: set correct target port #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
force-pushed
the
fix_invalid_port
branch
from
5f351af
to
5abf986
Compare
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
fix_invalid_port
branch
from
5abf986
to
c5a1996
Compare
jaronoff97
reviewed
Jul 16, 2024
jaronoff97
reviewed
Jul 16, 2024
| components.NewSinglePortParser("signalfx", 9943), | ||
| components.NewSinglePortParser("splunk_hec", 8088), | ||
| components.NewSinglePortParser("statsd", 8125, components.WithProtocol(corev1.ProtocolUDP)), | ||
| components.NewSinglePortParser("awsxray", 2000, components.WithTargetPort(2000)), |
There was a problem hiding this comment.
did we need to add this everywhere?
There was a problem hiding this comment.
Everywhere where we expect default ports and want to forward to the corresponding default target port.
There was a problem hiding this comment.
we only need this if we expect to open a different port than the port set on the service https://stackoverflow.com/questions/49981601/difference-between-targetport-and-port-in-kubernetes-service-definition
that being said, i don't think it's going to create trouble.
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
fix_invalid_port
branch
from
242b47b
to
decc8a0
Compare
jaronoff97
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue(s):
Testing:
Documentation: