-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e tests for java auto-instrumentation #498
Merged
VineethReddy02
merged 8 commits into
open-telemetry:main
from
pavolloffay:instrumentation-e2e-test
Nov 5, 2021
Merged
Add e2e tests for java auto-instrumentation #498
VineethReddy02
merged 8 commits into
open-telemetry:main
from
pavolloffay:instrumentation-e2e-test
Nov 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please do not merge yet! |
pavolloffay
commented
Nov 3, 2021
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
cebd4e5
to
668d810
Compare
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
You can also mark the PR as draft to prevent it from being merged :-) |
This is ready for review |
@VineethReddy02, could you please review this one? |
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
VineethReddy02
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
* Add e2e tests for java auto-instrumentation Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Add e2e tests for java auto-instrumentation Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay p.loffay@gmail.com