Add liveness probe to created container if otelcol configuration supports a health_check. #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orts a health_check. Fixes open-telemetry#571 Signed-off-by: Adrian Kostrubiak <adrian.kostrubiak@tomtom.com>
jpkrohling
reviewed
Nov 24, 2021
…empty; refine how we choose a healthcheck extension; rework tests to be table drive, flesh out a few more cases;
|
@jpkrohling, thanks for the feedback - I appreciate it. I pushed updates to address your feedback. |
jpkrohling
reviewed
Nov 25, 2021
There was a problem hiding this comment.
Looks good, just get the test under the same package as the code, so that the errors can be kept local. I know there's an argument about exposing the errors as part of the public API, but I don't think it's what we are currently doing in this repo at the moment.
adriankostrubiak-tomtom
changed the title
jpkrohling
approved these changes
Nov 25, 2021
jpkrohling
approved these changes
Nov 25, 2021
jpkrohling
approved these changes
Nov 26, 2021
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
…orts a health_check. (open-telemetry#574) * Add liveness probe to created container if otelcol configuration supports a health_check. Fixes open-telemetry#571 Signed-off-by: Adrian Kostrubiak <adrian.kostrubiak@tomtom.com>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…orts a health_check. (open-telemetry#574) * Add liveness probe to created container if otelcol configuration supports a health_check. Fixes open-telemetry#571 Signed-off-by: Adrian Kostrubiak <adrian.kostrubiak@tomtom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add liveness probe to created container if otelcol configuration supports a health_check.
Fixes #571
Signed-off-by: Adrian Kostrubiak adrian.kostrubiak@tomtom.com