Storing upgrade status into events #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
|
Fixes #486 |
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
|
@VineethReddy02 , @pavolloffay , @jpkrohling . Could you please review it? |
|
@jpkrohling, could you please have a look? |
|
Resolves #486 |
jpkrohling
reviewed
Feb 15, 2022
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
jpkrohling
approved these changes
Feb 16, 2022
|
I'm requesting a review from @pavolloffay as well, as he was part of the discussion about moving from messages to events. |
|
Hi @pavolloffay, could you please review it? |
pavolloffay
reviewed
Feb 21, 2022
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
|
@pavolloffay , could you please review it again? |
pavolloffay
reviewed
Feb 22, 2022
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
pavolloffay
approved these changes
Feb 22, 2022
6 tasks
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Storing upgrade status on events Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Fixing Lint nits Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Fixing test checks and converting messages to events Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Fixing upgrade test Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Fixing var value of expected version Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Fixing var value of expected version Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Change upgrade script fo v0.19.0 Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Created const for RecordBufferSize and Removed commented lines Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed function signature and type name Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed variable exposure Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuri Sa yurimsa@gmail.com
Resolves #486