Support nodeSelector field for non-sidecar collectors #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VineethReddy02
requested changes
Mar 22, 2022
pavolloffay
reviewed
Mar 25, 2022
|
@jutley the PR needs rebasing |
Signed-off-by: Jake Utley <jutley@hiya.com>
Signed-off-by: Jake Utley <jutley@hiya.com>
Signed-off-by: Jake Utley <jutley@hiya.com>
Signed-off-by: Jake Utley <jutley@hiya.com>
Signed-off-by: Jake Utley <jutley@hiya.com>
Signed-off-by: Jake Utley <jutley@hiya.com>
Signed-off-by: Jake Utley <jutley@hiya.com>
Signed-off-by: Jake Utley <jutley@hiya.com>
|
@pavolloffay Just rebased it. |
|
Tests started. |
pavolloffay
approved these changes
Apr 7, 2022
VineethReddy02
approved these changes
Apr 7, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…#789) * Support nodeSelector field for non-sidecar collectors Signed-off-by: Jake Utley <jutley@hiya.com> * Add tests for nodeSelector Signed-off-by: Jake Utley <jutley@hiya.com> * Revise resource names in tests Signed-off-by: Jake Utley <jutley@hiya.com> * Run make bundle Signed-off-by: Jake Utley <jutley@hiya.com> * More automated changes after 'make test' Signed-off-by: Jake Utley <jutley@hiya.com> * Manually revert changes to kustomization.yaml Signed-off-by: Jake Utley <jutley@hiya.com> * Revise field description Signed-off-by: Jake Utley <jutley@hiya.com> * Use open-telemetry image repo Signed-off-by: Jake Utley <jutley@hiya.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying a nodeSelector on collectors (unless they are sidecars). This allows users to schedule their collectors onto specific node pools. Fixes #779