Including new label #797
Merged
Including new label #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
frzifus
reviewed
Mar 28, 2022
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
frzifus
reviewed
Apr 1, 2022
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
jpkrohling
approved these changes
Apr 5, 2022
|
I think this broke deployments that deploy containers with sha256 hashes. A k8s label is limited to 63 characters, and a sh256 hash is 64 characters, resulting in errors like `
|
|
Yeah, this introduced a breaking regression per #879 @yuriolisa @jpkrohling |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…elemetry#797) * Including new label Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Checking len of version var Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Fixing function signature Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Fixing linters Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Fixing number of labels in test files Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Test len of label version for configmap Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added missing len check Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuri Sa yurimsa@gmail.com
Resolves #394