Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick update pass #20

Merged
merged 3 commits into from Oct 18, 2021
Merged

Conversation

Blacksmoke16
Copy link
Contributor

@Blacksmoke16 Blacksmoke16 commented Oct 12, 2021

Does a quick pass to update some things related to changes made in the main lib. This repo could use some more work, but this should at least make CI happy. I don't really have a way verify these changes, other than the unit tests.

  • Fix tests
  • Use Docker image
  • Require min of PHP 7.3
  • Exclude examples from static analysis for now

Resolves #19

Use Docker image
Require min of PHP 7.3
Exclude examples from static analysis for now
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #20 (cbf0aef) into main (29fb65f) will increase coverage by 0.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #20      +/-   ##
============================================
+ Coverage     88.73%   89.28%   +0.55%     
+ Complexity       88       86       -2     
============================================
  Files             6        6              
  Lines           213      224      +11     
============================================
+ Hits            189      200      +11     
  Misses           24       24              
Impacted Files Coverage Δ
detectors/aws/Ec2Detector.php 97.01% <ø> (ø)
detectors/aws/EcsDetector.php 80.00% <ø> (ø)
detectors/aws/EksDetector.php 70.68% <ø> (ø)
detectors/aws/LambdaDetector.php 100.00% <ø> (ø)
instrumentation/aws/xray/AwsXrayIdGenerator.php 100.00% <ø> (ø)
propagators/aws/xray/AwsXrayPropagator.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29fb65f...cbf0aef. Read the comment docs.

@bobstrecansky
Copy link
Collaborator

That Pslam error is sort of strange to me. Wondering if we should try and fix it or move through.

@bobstrecansky bobstrecansky merged commit 16db5d6 into open-telemetry:main Oct 18, 2021
@Blacksmoke16 Blacksmoke16 deleted the fix-tests branch October 18, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants