Isolate exception state for hooks #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoallikmaa
requested review from
bobstrecansky,
brettmc and
pdelewski
as code owners
brettmc
reviewed
Jan 21, 2024
Fixed formatting and PECL package list. However there seems to be some genuine bug on Windows with these changes, will investigate that. |
|
Somehow |
brettmc
approved these changes
Jan 22, 2024
brettmc
added a commit
to brettmc/opentelemetry-php-instrumentation
that referenced
this pull request
Jan 22, 2024
if an invalid typehint is provided for first param of post callback, this would previously cause a hang. fixed by previous open-telemetry#118, this test confirms the fix works in this scenario.
brettmc
added a commit
to brettmc/opentelemetry-php-instrumentation
that referenced
this pull request
Jan 22, 2024
if an invalid typehint is provided for first param of post callback, this would previously cause a hang. fixed by open-telemetry#118, this test confirms the fix works in this scenario.
brettmc
added a commit
that referenced
this pull request
Jan 23, 2024
* adding test for post hook type error if an invalid typehint is provided for first param of post callback, this would previously cause a hang. fixed by #118, this test confirms the fix works in this scenario. * improve test, add to package.xml * remove try/catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves open-telemetry/opentelemetry-php#1150
This saves the values of the following globals before hook functions are called:
These values are then reset to as if there is no exception raised currently. There should ideally be no exception raised at the moment this is called anyway, but this is just in case something has raised an internal exception (could be another observer for example). After the hook function, the old state of those values is restored, and if an exception was thrown by the hook, that is captured separately and logged as a warning.
Tested that the scenario from the issue mentioned above is fixed with this, and added that exact scenario as a test.