Adding 'all' as an option for disabling auto instrumentations (#1220)

open-telemetry · Jan 24, 2024 · f2ab3c5 · f2ab3c5
1 parent 810aa2f
commit f2ab3c5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/SDK/Sdk.php b/src/SDK/Sdk.php
@@ -13,6 +13,8 @@
 
 class Sdk
 {
+    private const OTEL_PHP_DISABLED_INSTRUMENTATIONS_ALL = 'all';
+
     private TracerProviderInterface $tracerProvider;
     private MeterProviderInterface $meterProvider;
     private LoggerProviderInterface $loggerProvider;
@@ -40,7 +42,9 @@ public static function isDisabled(): bool
      */
     public static function isInstrumentationDisabled(string $name): bool
     {
-        return in_array($name, Configuration::getList(Variables::OTEL_PHP_DISABLED_INSTRUMENTATIONS));
+        $disabledInstrumentations = Configuration::getList(Variables::OTEL_PHP_DISABLED_INSTRUMENTATIONS);
+
+        return [self::OTEL_PHP_DISABLED_INSTRUMENTATIONS_ALL] === $disabledInstrumentations || in_array($name, $disabledInstrumentations);
     }
 
     public static function builder(): SdkBuilder

diff --git a/tests/Unit/SDK/SdkTest.php b/tests/Unit/SDK/SdkTest.php
@@ -65,6 +65,9 @@ public static function instrumentationDisabledProvider(): array
             ['foo,bar', 'bar', true],
             ['', 'foo', false],
             ['foo', 'foo', true],
+            ['all', 'foo', true],
+            ['all,bar', 'foo', false],
+            ['all,foo', 'foo', true],
         ];
     }