Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[meta] php 8.1 support #516

Closed
2 of 3 tasks
brettmc opened this issue Dec 16, 2021 · 3 comments
Closed
2 of 3 tasks

[meta] php 8.1 support #516

brettmc opened this issue Dec 16, 2021 · 3 comments
Labels
help wanted This issue is looking for someone to work on it php8.1

Comments

@brettmc
Copy link
Collaborator

brettmc commented Dec 16, 2021 •
edited
Loading

PHP 8.1 has been released, and there are some issues to fix to make the library compatible.

Issues that we are currently aware of with opentelemetry-php + 8.1:
@brettmc brettmc added bug Something isn't working php8.1 labels Dec 16, 2021
@brettmc brettmc pinned this issue Dec 16, 2021
@brettmc brettmc added help wanted This issue is looking for someone to work on it and removed bug Something isn't working labels Dec 16, 2021
@brettmc
Copy link
Collaborator Author

brettmc commented Jan 6, 2022

there are two PRs against protobuf which address 8.1 deprecation notices, so hopefully one will be accepted and will make its way through into a release. I've tested otel-php against my PR, and it removes/silences all notices.

@brettmc brettmc mentioned this issue Jan 8, 2022
Merged
@brettmc
Copy link
Collaborator Author

brettmc commented Feb 2, 2022

Nearly there - my google/protobuf PR has been merged, so whenever the next release comes out (3.19.5 or 3.20.0), our 8.1 tests should start passing.

@bobstrecansky
Copy link
Collaborator

I think we can close this now because this fix has been hotpatched upstream.

@bobstrecansky bobstrecansky unpinned this issue Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted This issue is looking for someone to work on it php8.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobstrecansky @brettmc