Updating README.md #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making a note about our first meeting.
SergeyKanzhelev
approved these changes
Sep 30, 2019
tidal
pushed a commit
that referenced
this pull request
Feb 28, 2022
* Scaffold the new exporter and helper class * Make the SpanConverter compliant to the interface the others are * Removing check already covered by SpanExporterTrait * Adding in scaffolding for a happy path test through the new code * Fix bugs when path is present or endpoint scheme is https * Remove type doc to fix psalm errors * Comment out doc type to fix phan issue * Fix style * Add missing type in constructor * Shorten ternary * Inline function calls in doExport * Inline function calls in doExport * Revert ternary condensation commit from earlier * Not requiring a port be set in the endpoint URL and inferring it from the scheme when it's missing * Try adjusting thttpclient with a subclass instead of adapter (#2) * Setup the exporter for injecting a psr-18 client * Switch to using a subclass of THttpCLient * Getting the psr-18 client into the subclass * Copy verbatim from THttpCLient the method that needs working * Getting the request and stream factories in there too * Migrating the headers over to use the psr18 and psr7 things * Migrating over the body * Commenting out some more things Otel doesn't need * Commenting out the rest as it seems accounted for * Removing the last of the old implementation * Fix to undefined variable from previous commit * Actually otel isn't using any custom headers so we don't need to handle those either * Remove all the commented out code * Updating fromConnectionString to use the discovery helpers to find and inject the PSR-18 and PSR-7 classes HttpCollectorExporter needs * Reworking happy path test to use mocks of the PSR-18/PSR-7 interfaces * Turning TODO in to comment * Adjust line breaks * Fix style * Fix potential array key access error Phan noticed * Ignore psalm false positives in the test file * Workaround odd psalm bug/behavior of surfacing errors in THttpClient after it's been subclassed * Switch to correct shortening of ternaries this time * Minimal changes needed to drop dependence on THttpClient * Moving some of the setters into the constructor now that the THttpClient superclass is gone * Cleaning up endpointURL duplication and removing host_ member that's not really needed anymore * Naming the copied over buf_ member a little more explicitly * Naming the main test object in the span converter test class more clearly * Renaming 2 of the files/classes to be more clear * Remove inaccurate copy pasta leftover from THttpClient * Fix style * Factor out a helper object for parsing the endpoints to help satisfy Phan * Have codecov pick up on the hlper class for code coverage * Refactor the UDP exporter to also use the new ParsedEndpointUrl helper class * Fix style * Psalm makes a good point that the defaults for host/port in the UDP exporter can never be hit since the entry point requires them to be present in the endpoint URL
mxiamxia
pushed a commit
to mxiamxia/opentelemetry-php
that referenced
this pull request
Feb 9, 2024
…strumentation-sample-apps Integration Test App for AWS SDK Instrumentation in OpenTelemetry PHP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a note about our first meeting.