Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow decoration of zipkin span converter #608

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Allow decoration of zipkin span converter #608

merged 2 commits into from
Apr 21, 2022

Conversation

cdaguerre
Copy link
Contributor

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 15, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cdaguerre / name: Christian Daguerre (2505bc6)

@bobstrecansky
Copy link
Collaborator

@cdaguerre - I think there are just some phan fixes necessary in the CI and then I believe we'll be good to go here!

@brettmc
Copy link
Collaborator

brettmc commented Mar 16, 2022

Those phan issues are fixed upstream now, so just merging upstream/main into your branch should make everything green

@bobstrecansky
Copy link
Collaborator

I pulled down your branch locally and validated - removing the 4 phpstan annotations around the errored lines let phpstan pass in this PR. That should be all we need to change for this PR to turn green I think.

@bobstrecansky
Copy link
Collaborator

@cdaguerre - would you like to make those PHP stan annotation fixes so we can merge this PR?

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #608 (54e8654) into main (1d5283b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #608   +/-   ##
=========================================
  Coverage     84.28%   84.28%           
  Complexity     1153     1153           
=========================================
  Files           128      128           
  Lines          2788     2788           
=========================================
  Hits           2350     2350           
  Misses          438      438           
Flag Coverage Δ
7.4 84.23% <ø> (ø)
8.0 84.28% <ø> (ø)
8.1 84.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Contrib/Zipkin/Exporter.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d5283b...54e8654. Read the comment docs.

@brettmc brettmc merged commit 9138d78 into open-telemetry:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants