Add @group annotation to compliance tests for environment variables #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuktea
requested review from
bobstrecansky,
zsistla,
tidal and
brettmc
as code owners
Marked tests for environment variables with phpunit @group annotations to identify compliance tests. This enables for a way to run just those specific test and will serve as a useful form of documentation.
yuktea
force-pushed
the
add-annotation-for-compliance-test
branch
from
95ce868
to
dcf3844
Compare
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
=========================================
Coverage 84.45% 84.45%
Complexity 1141 1141
=========================================
Files 127 127
Lines 2766 2766
=========================================
Hits 2336 2336
Misses 430 430
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
This looks like a great start! We should probably also have a Makefile task that looks something like this: In order to be able to complete these compliance tests in a standalone fashion. |
brettmc
approved these changes
Mar 31, 2022
brettmc
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked the compliance tests for environment variables with phpunit notion (
@group compliance). This helps to identify the tests used for verifying compliance to the spec-compliance-matrix