Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test based on the Jaeger spec #645

Merged
merged 5 commits into from
Mar 31, 2022

Conversation

Grunet
Copy link
Contributor

@Grunet Grunet commented Mar 31, 2022

Adds a specific test based on the spec example, since I tried at least twice at the logic and missed both times until @saktib fixed it all up...

Also fixes up some flakiness I noticed after running the tests a few times, like here https://github.com/open-telemetry/opentelemetry-php/runs/5763933166?check_suite_focus=true

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #645 (9088731) into main (178cc9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #645   +/-   ##
=========================================
  Coverage     84.45%   84.45%           
  Complexity     1141     1141           
=========================================
  Files           127      127           
  Lines          2766     2766           
=========================================
  Hits           2336     2336           
  Misses          430      430           
Flag Coverage Δ
7.4 84.40% <ø> (ø)
8.0 84.45% <ø> (ø)
8.1 84.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178cc9e...9088731. Read the comment docs.

@Grunet Grunet marked this pull request as ready for review March 31, 2022 01:57
@brettmc brettmc merged commit ca05f51 into open-telemetry:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants